diff options
| author | Markus Heiser <markus.heiser@darmarit.de> | 2023-10-02 16:36:07 +0200 |
|---|---|---|
| committer | Markus Heiser <markus.heiser@darmarIT.de> | 2023-11-01 06:44:56 +0100 |
| commit | fd814aac863673047c46a9d80682415dae180969 (patch) | |
| tree | 52ea45e433ebfb8cb4e82f69a01413cc4b0c13d3 /searx/plugins/limiter.py | |
| parent | b05a15540e1dc2dfb8e4e25aa537b2a68e713844 (diff) | |
[mod] isolation of botdetection from the limiter
This patch was inspired by the discussion around PR-2882 [2]. The goals of this
patch are:
1. Convert plugin searx.plugin.limiter to normal code [1]
2. isolation of botdetection from the limiter [2]
3. searx/{tools => botdetection}/config.py and drop searx.tools
4. in URL /config, 'limiter.enabled' is true only if the limiter is really
enabled (Redis is available).
This patch moves all the code that belongs to botdetection into namespace
searx.botdetection and code that belongs to limiter is placed in namespace
searx.limiter.
Tthe limiter used to be a plugin at some point botdetection was added, it was
not a plugin. The modularization of these two components was long overdue.
With the clear modularization, the documentation could then also be organized
according to the architecture.
[1] https://github.com/searxng/searxng/pull/2882
[2] https://github.com/searxng/searxng/pull/2882#issuecomment-1741716891
To test:
- check the app works without the limiter, check `/config`
- check the app works with the limiter and with the token, check `/config`
- make docs.live .. and read
- http://0.0.0.0:8000/admin/searx.limiter.html
- http://0.0.0.0:8000/src/searx.botdetection.html#botdetection
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Diffstat (limited to 'searx/plugins/limiter.py')
| -rw-r--r-- | searx/plugins/limiter.py | 38 |
1 files changed, 0 insertions, 38 deletions
diff --git a/searx/plugins/limiter.py b/searx/plugins/limiter.py deleted file mode 100644 index 24b14f3b4..000000000 --- a/searx/plugins/limiter.py +++ /dev/null @@ -1,38 +0,0 @@ -# SPDX-License-Identifier: AGPL-3.0-or-later -# lint: pylint -# pyright: basic -"""see :ref:`limiter src`""" - -import sys -import flask - -from searx import redisdb -from searx.plugins import logger -from searx.botdetection import limiter - -name = "Request limiter" -description = "Limit the number of request" -default_on = False -preference_section = 'service' - -logger = logger.getChild('limiter') - - -def pre_request(): - """See :ref:`flask.Flask.before_request`""" - return limiter.filter_request(flask.request) - - -def init(app: flask.Flask, settings) -> bool: - if not settings['server']['limiter'] and not settings['server']['public_instance']: - return False - if not redisdb.client(): - logger.error( - "The limiter requires Redis, please consult the documentation: " - + "https://docs.searxng.org/admin/searx.botdetection.html#limiter" - ) - if settings['server']['public_instance']: - sys.exit(1) - return False - app.before_request(pre_request) - return True |