summaryrefslogtreecommitdiff
path: root/searx/engines/dictzone.py
diff options
context:
space:
mode:
authorMarkus Heiser <markus.heiser@darmarit.de>2025-01-27 16:43:43 +0100
committerMarkus Heiser <markus.heiser@darmarIT.de>2025-01-28 07:07:08 +0100
commit36a1ef12399d529f210ceb4f8b28f497fabd0834 (patch)
tree4015a316c6505c3e52d43eea7137338331cbd4eb /searx/engines/dictzone.py
parentedfbf1e1183815cea3b723f3b66260bc55679f32 (diff)
[refactor] typification of SearXNG / EngineResults
In [1] and [2] we discussed the need of a Result.results property and how we can avoid unclear code. This patch implements a class for the reslut-lists of engines:: searx.result_types.EngineResults A simple example for the usage in engine development:: from searx.result_types import EngineResults ... def response(resp) -> EngineResults: res = EngineResults() ... res.add( res.types.Answer(answer="lorem ipsum ..", url="https://example.org") ) ... return res [1] https://github.com/searxng/searxng/pull/4183#pullrequestreview-257400034 [2] https://github.com/searxng/searxng/pull/4183#issuecomment-2614301580 Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Diffstat (limited to 'searx/engines/dictzone.py')
-rw-r--r--searx/engines/dictzone.py12
1 files changed, 6 insertions, 6 deletions
diff --git a/searx/engines/dictzone.py b/searx/engines/dictzone.py
index 7f562c716..83ab28ff2 100644
--- a/searx/engines/dictzone.py
+++ b/searx/engines/dictzone.py
@@ -7,7 +7,7 @@ import urllib.parse
from lxml import html
from searx.utils import eval_xpath, extract_text
-from searx.result_types import Translations
+from searx.result_types import EngineResults
from searx.network import get as http_get # https://github.com/searxng/searxng/issues/762
# about
@@ -43,9 +43,9 @@ def _clean_up_node(node):
n.getparent().remove(n)
-def response(resp):
+def response(resp) -> EngineResults:
+ results = EngineResults()
- results = []
item_list = []
if not resp.ok:
@@ -85,7 +85,7 @@ def response(resp):
synonyms.append(p_text)
- item = Translations.Item(text=text, synonyms=synonyms)
+ item = results.types.Translations.Item(text=text, synonyms=synonyms)
item_list.append(item)
# the "autotranslate" of dictzone is loaded by the JS from URL:
@@ -98,7 +98,7 @@ def response(resp):
# works only sometimes?
autotranslate = http_get(f"{base_url}/trans/{query}/{from_lang}_{to_lang}", timeout=1.0)
if autotranslate.ok and autotranslate.text:
- item_list.insert(0, Translations.Item(text=autotranslate.text))
+ item_list.insert(0, results.types.Translations.Item(text=autotranslate.text))
- Translations(results=results, translations=item_list, url=resp.search_params["url"])
+ results.add(results.types.Translations(translations=item_list, url=resp.search_params["url"]))
return results