summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIvan Gabaldon <igabaldon@inetol.net>2025-05-11 18:39:25 +0200
committerAlexandre Flament <alex@al-f.net>2025-05-11 19:28:51 +0200
commitda3c640cef71032bced6f4e8baf1665801cdc4b9 (patch)
tree26e6495c99c39a876bd13a835416bd68accc88c0
parentd16854e67a5bf2f640aabf119c9b50f5a1a3f24f (diff)
revert using null keyword
env.DOCKERHUB_USERNAME shouldn't be an empty string as it's defined and set (I think, I can't see this). Even if wasn't defined, GitHub Org/Repo wide envs/secrets should return an empty string (?)
-rw-r--r--.github/workflows/container.yml8
1 files changed, 4 insertions, 4 deletions
diff --git a/.github/workflows/container.yml b/.github/workflows/container.yml
index d232a0737..ee1093acb 100644
--- a/.github/workflows/container.yml
+++ b/.github/workflows/container.yml
@@ -153,13 +153,13 @@ jobs:
- test
steps:
- - if: env.DOCKERHUB_USERNAME != ''
+ - if: env.DOCKERHUB_USERNAME != null
name: Checkout
uses: actions/checkout@v4
with:
persist-credentials: "false"
- - if: env.DOCKERHUB_USERNAME != ''
+ - if: env.DOCKERHUB_USERNAME != null
name: Login to GHCR
uses: docker/login-action@v3
with:
@@ -167,7 +167,7 @@ jobs:
username: "${{ github.repository_owner }}"
password: "${{ secrets.GITHUB_TOKEN }}"
- - if: env.DOCKERHUB_USERNAME != ''
+ - if: env.DOCKERHUB_USERNAME != null
name: Login to Docker Hub
uses: docker/login-action@v3
with:
@@ -175,7 +175,7 @@ jobs:
username: "${{ env.DOCKERHUB_USERNAME }}"
password: "${{ secrets.DOCKERHUB_TOKEN }}"
- - if: env.DOCKERHUB_USERNAME != ''
+ - if: env.DOCKERHUB_USERNAME != null
name: Release
env:
GIT_URL: "${{ needs.build.outputs.git_url }}"