From bb04699b17e014089e6dd6d0af2f01b9717ad58c Mon Sep 17 00:00:00 2001 From: Markus Heiser Date: Wed, 30 Oct 2024 13:16:31 +0100 Subject: [fix] unit tests: call searx.search.initialize in test's setUp Depending on the order the unit tests are executed, the searx.search module is initalized or not, issue reported in [1]:: Traceback (most recent call last): File "searxng/tests/unit/test_results.py", line 72, in test_result_merge_by_title self.container.extend('stract', [fake_result(engine='stract', title='short title')]) File "searxng/searx/results.py", line 243, in extend histogram_observe(standard_result_count, 'engine', engine_name, 'result', 'count') File "searxng/searx/metrics/__init__.py", line 49, in histogram_observe histogram_storage.get(*args).observe(duration) ^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'get' To ensure that the searx.search module is initialized, the - searx.engines.load_engines is replace by - searx.search.initialize [1] https://github.com/searxng/searxng/pull/3932#discussion_r1822406569 Signed-off-by: Markus Heiser --- tests/unit/test_query.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tests/unit/test_query.py') diff --git a/tests/unit/test_query.py b/tests/unit/test_query.py index 601a6e60d..00c53edc7 100644 --- a/tests/unit/test_query.py +++ b/tests/unit/test_query.py @@ -2,7 +2,7 @@ # pylint: disable=missing-module-docstring from parameterized.parameterized import parameterized -from searx.engines import load_engines +import searx.search from searx.query import RawTextQuery from tests import SearxTestCase @@ -218,10 +218,10 @@ class TestBang(SearxTestCase): # pylint:disable=missing-class-docstring THE_QUERY = 'the query' def setUp(self): - load_engines(TEST_ENGINES) + searx.search.initialize(TEST_ENGINES) def tearDown(self): - load_engines([]) + searx.search.load_engines([]) @parameterized.expand(SPECIFIC_BANGS) def test_bang(self, bang: str): -- cgit v1.2.3