From 36a1ef12399d529f210ceb4f8b28f497fabd0834 Mon Sep 17 00:00:00 2001 From: Markus Heiser Date: Mon, 27 Jan 2025 16:43:43 +0100 Subject: [refactor] typification of SearXNG / EngineResults In [1] and [2] we discussed the need of a Result.results property and how we can avoid unclear code. This patch implements a class for the reslut-lists of engines:: searx.result_types.EngineResults A simple example for the usage in engine development:: from searx.result_types import EngineResults ... def response(resp) -> EngineResults: res = EngineResults() ... res.add( res.types.Answer(answer="lorem ipsum ..", url="https://example.org") ) ... return res [1] https://github.com/searxng/searxng/pull/4183#pullrequestreview-257400034 [2] https://github.com/searxng/searxng/pull/4183#issuecomment-2614301580 Signed-off-by: Markus Heiser --- searx/engines/translated.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'searx/engines/translated.py') diff --git a/searx/engines/translated.py b/searx/engines/translated.py index 632e3d2e1..cffb6eda3 100644 --- a/searx/engines/translated.py +++ b/searx/engines/translated.py @@ -5,7 +5,7 @@ import urllib.parse -from searx.result_types import Translations +from searx.result_types import EngineResults # about about = { @@ -37,8 +37,8 @@ def request(query, params): # pylint: disable=unused-argument return params -def response(resp): - results = [] +def response(resp) -> EngineResults: + results = EngineResults() data = resp.json() args = { @@ -53,7 +53,7 @@ def response(resp): examples = [f"{m['segment']} : {m['translation']}" for m in data['matches'] if m['translation'] != text] - item = Translations.Item(text=text, examples=examples) - Translations(results=results, translations=[item], url=link) + item = results.types.Translations.Item(text=text, examples=examples) + results.add(results.types.Translations(translations=[item], url=link)) return results -- cgit v1.2.3