From 36a1ef12399d529f210ceb4f8b28f497fabd0834 Mon Sep 17 00:00:00 2001 From: Markus Heiser Date: Mon, 27 Jan 2025 16:43:43 +0100 Subject: [refactor] typification of SearXNG / EngineResults In [1] and [2] we discussed the need of a Result.results property and how we can avoid unclear code. This patch implements a class for the reslut-lists of engines:: searx.result_types.EngineResults A simple example for the usage in engine development:: from searx.result_types import EngineResults ... def response(resp) -> EngineResults: res = EngineResults() ... res.add( res.types.Answer(answer="lorem ipsum ..", url="https://example.org") ) ... return res [1] https://github.com/searxng/searxng/pull/4183#pullrequestreview-257400034 [2] https://github.com/searxng/searxng/pull/4183#issuecomment-2614301580 Signed-off-by: Markus Heiser --- searx/engines/libretranslate.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'searx/engines/libretranslate.py') diff --git a/searx/engines/libretranslate.py b/searx/engines/libretranslate.py index 2e6663cb0..b9b8c7165 100644 --- a/searx/engines/libretranslate.py +++ b/searx/engines/libretranslate.py @@ -3,7 +3,7 @@ import random import json -from searx.result_types import Translations +from searx.result_types import EngineResults about = { "website": 'https://libretranslate.com', @@ -45,15 +45,15 @@ def request(_query, params): return params -def response(resp): - results = [] +def response(resp) -> EngineResults: + results = EngineResults() json_resp = resp.json() text = json_resp.get('translatedText') if not text: return results - item = Translations.Item(text=text, examples=json_resp.get('alternatives', [])) - Translations(results=results, translations=[item]) + item = results.types.Translations.Item(text=text, examples=json_resp.get('alternatives', [])) + results.add(results.types.Translations(translations=[item])) return results -- cgit v1.2.3