From 36a1ef12399d529f210ceb4f8b28f497fabd0834 Mon Sep 17 00:00:00 2001 From: Markus Heiser Date: Mon, 27 Jan 2025 16:43:43 +0100 Subject: [refactor] typification of SearXNG / EngineResults In [1] and [2] we discussed the need of a Result.results property and how we can avoid unclear code. This patch implements a class for the reslut-lists of engines:: searx.result_types.EngineResults A simple example for the usage in engine development:: from searx.result_types import EngineResults ... def response(resp) -> EngineResults: res = EngineResults() ... res.add( res.types.Answer(answer="lorem ipsum ..", url="https://example.org") ) ... return res [1] https://github.com/searxng/searxng/pull/4183#pullrequestreview-257400034 [2] https://github.com/searxng/searxng/pull/4183#issuecomment-2614301580 Signed-off-by: Markus Heiser --- searx/engines/deepl.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'searx/engines/deepl.py') diff --git a/searx/engines/deepl.py b/searx/engines/deepl.py index eff746b6f..aec17076f 100644 --- a/searx/engines/deepl.py +++ b/searx/engines/deepl.py @@ -1,7 +1,7 @@ # SPDX-License-Identifier: AGPL-3.0-or-later """Deepl translation engine""" -from searx.result_types import Translations +from searx.result_types import EngineResults about = { "website": 'https://deepl.com', @@ -39,15 +39,14 @@ def request(_query, params): return params -def response(resp): - results = [] +def response(resp) -> EngineResults: - result = resp.json() + res = EngineResults() + data = resp.json() + if not data.get('translations'): + return res - if not result.get('translations'): - return results + translations = [res.types.Translations.Item(text=t['text']) for t in data['translations']] + res.add(res.types.Translations(translations=translations)) - translations = [Translations.Item(text=t['text']) for t in result['translations']] - Translations(results=results, translations=translations) - - return results + return res -- cgit v1.2.3