From 5d9188c7e93f010f1d1d8d88d3b0791d54621b6c Mon Sep 17 00:00:00 2001 From: Markus Heiser Date: Wed, 19 Jan 2022 10:14:39 +0100 Subject: [mod] add pyright to nvm's node installation Pyright [1] is in the nvm enviroment, may be you need to rebuild the nvm environment and install nodejs in:: ./manage nvm.clean ./manage nvm.nodejs The last command installs nodejs and the packages from .nvm_packages. You can test your pyright installation, to get a bash within the nvm run:: ./manage nvm.bash (nvm) $ which pyright ./.nvm/versions/node/v16.13.0/bin/pyright If you have a local nvm in your HOME folder, the output from ``which`` is different. Press ``[CTRL-D]`` to get out of this bash. [1] https://github.com/microsoft/pyright Signed-off-by: Markus Heiser --- .nvm_packages | 1 + 1 file changed, 1 insertion(+) (limited to '.nvm_packages') diff --git a/.nvm_packages b/.nvm_packages index 13eabc5c2..fe8585c3b 100644 --- a/.nvm_packages +++ b/.nvm_packages @@ -5,4 +5,5 @@ # [1] https://github.com/nvm-sh/nvm#default-global-packages-from-file-while-installing eslint +pyright -- cgit v1.2.3 From 6d701d2fea07198807351c7c4856001c0f1ebffb Mon Sep 17 00:00:00 2001 From: Martin Fischer Date: Thu, 20 Jan 2022 09:11:37 +0100 Subject: [fix] ensure that test.pyright installs pyright nodejs.ensure only sets up NVM if there isn't a system-wide installation of Node that matches our NODE_MINIMUM_VERSION. The ubuntu image in the CI comes with an up to date node version, so pyright from .nvm_packages is never installed. This commit fixes this by introducing a package.json file. --- .nvm_packages | 1 - 1 file changed, 1 deletion(-) (limited to '.nvm_packages') diff --git a/.nvm_packages b/.nvm_packages index fe8585c3b..13eabc5c2 100644 --- a/.nvm_packages +++ b/.nvm_packages @@ -5,5 +5,4 @@ # [1] https://github.com/nvm-sh/nvm#default-global-packages-from-file-while-installing eslint -pyright -- cgit v1.2.3 From cac03529860e0fd19585b35a66f5de4f0ea0559d Mon Sep 17 00:00:00 2001 From: Martin Fischer Date: Fri, 21 Jan 2022 17:34:25 +0100 Subject: [mod] remove .nvm_packages, add eslint to package.json --- .nvm_packages | 8 -------- 1 file changed, 8 deletions(-) delete mode 100644 .nvm_packages (limited to '.nvm_packages') diff --git a/.nvm_packages b/.nvm_packages deleted file mode 100644 index 13eabc5c2..000000000 --- a/.nvm_packages +++ /dev/null @@ -1,8 +0,0 @@ -# -*- coding: utf-8; mode: conf-unix -*- -# -# Developement tools pre-installed in NVM's node installation [1] -# -# [1] https://github.com/nvm-sh/nvm#default-global-packages-from-file-while-installing - -eslint - -- cgit v1.2.3